Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Delete unused/out-dated primitives #1704

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Jul 12, 2021

any_of_adj_matrix_row & transform_reduce_v_with_adj_matrix_row (graph primitives) were initially added to be used in error checking but they are no longer used (and may not be used in the future as well).

Deleting the dead code.

@seunghwak seunghwak requested a review from a team as a code owner July 12, 2021 02:31
@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 12, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #1704 (ac381c9) into branch-21.08 (aba3445) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ac381c9 differs from pull request most recent head 649dfed. Consider uploading reports for the commit 649dfed to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #1704      +/-   ##
================================================
+ Coverage         59.31%   59.34%   +0.02%     
================================================
  Files                80       80              
  Lines              3557     3559       +2     
================================================
+ Hits               2110     2112       +2     
  Misses             1447     1447              
Impacted Files Coverage Δ
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba3445...649dfed. Read the comment docs.

@seunghwak seunghwak changed the title Delete any_of_adj_matrix_row Delete unused/out-dated primitives Jul 12, 2021
@BradReesWork BradReesWork added this to the 21.08 milestone Jul 12, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1a63602 into rapidsai:branch-21.08 Jul 12, 2021
@seunghwak seunghwak deleted the enh_remove_unused branch October 19, 2021 20:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants