Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add options to drop self-loops & multi_edges in C++ test graph generation #1934

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Add options to drop self-loops & multi_edges in C++ test graph generation #1934

merged 1 commit into from
Nov 11, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Nov 8, 2021 •
edited
Loading

Necessary for #1909

Add options to filter out self-loops & multi-edges after edge generation and before graph creation in C++ test graph generation API.

@seunghwak seunghwak added feature request New feature or request 3 - Ready for Review DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Nov 8, 2021
@seunghwak seunghwak added this to the 21.12 milestone Nov 8, 2021
@seunghwak seunghwak self-assigned this Nov 8, 2021
@seunghwak seunghwak requested a review from a team as a code owner November 8, 2021 17:30
@seunghwak seunghwak mentioned this pull request Nov 8, 2021
Merged
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@61950dd). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4167716 differs from pull request most recent head 3c301a4. Consider uploading reports for the commit 3c301a4 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1934   +/-   ##
===============================================
  Coverage                ?   70.04%           
===============================================
  Files                   ?      143           
  Lines                   ?     8904           
  Branches                ?        0           
===============================================
  Hits                    ?     6237           
  Misses                  ?     2667           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61950dd...3c301a4. Read the comment docs.

@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label Nov 9, 2021
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0730fea into rapidsai:branch-21.12 Nov 11, 2021
@seunghwak seunghwak deleted the fea_filter_test_graph branch January 27, 2022 20:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@kaatish kaatish Awaiting requested review from kaatish

Assignees

@seunghwak seunghwak

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
21.12
Development

Successfully merging this pull request may close these issues.
4 participants
@seunghwak @codecov-commenter @BradReesWork @ChuckHastings