Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Enforce renumbering for MNMG algos #1943

Merged
merged 7 commits into from
Nov 12, 2021

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Nov 11, 2021

A bug was reported when calling a MNMG algo with unrenumbered edge list.
This PR returns an error if renumber=False

Change the algo name for asv reporting

closes #1936

@jnke2016 jnke2016 requested a review from a team as a code owner November 11, 2021 20:07
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@0730fea). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1943   +/-   ##
===============================================
  Coverage                ?   70.28%           
===============================================
  Files                   ?      143           
  Lines                   ?     8922           
  Branches                ?        0           
===============================================
  Hits                    ?     6271           
  Misses                  ?     2651           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0730fea...aa5b349. Read the comment docs.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor change requests.

python/cugraph/cugraph/tests/dask/test_mg_renumber.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/dask/test_mg_renumber.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/tests/dask/test_mg_renumber.py Outdated Show resolved Hide resolved
@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Nov 11, 2021
@BradReesWork BradReesWork added this to the 21.12 milestone Nov 12, 2021
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5c8a5b7 into rapidsai:branch-21.12 Nov 12, 2021
@jnke2016 jnke2016 deleted the bug_enforce_renumbering branch September 24, 2022 23:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AttributeError: 'NoneType' object has no attribute 'implementation' when using dask_cugraph.louvain
4 participants