Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[DO NOT MERGE] Experiment to leverage CUDASTF #4833

Draft
wants to merge 10 commits into
base: branch-25.02
Choose a base branch
from

Conversation

caugonnet
Copy link

@caugonnet caugonnet commented Dec 12, 2024

This is intended to explore how we can use CUDASTF within cuGraph

Copy link

copy-pr-bot bot commented Dec 12, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@@ -15,6 +15,13 @@
# This function finds CCCL and sets any additional necessary environment variables.
function(find_and_configure_cccl)
include(${rapids-cmake-dir}/cpm/cccl.cmake)
include(${rapids-cmake-dir}/cpm/package_override.cmake)

rapids_cpm_package_override("${CMAKE_CURRENT_FUNCTION_LIST_DIR}/cccl_override.json")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be something we surround with some CUGRAPH_USE_STF option for example

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change DO NOT MERGE Hold off on merging; see PR for details and removed DO NOT MERGE Hold off on merging; see PR for details labels Dec 13, 2024
@caugonnet
Copy link
Author

/ok to test

@BradReesWork
Copy link
Member

/okay to test

cpp/tests/utilities/check_utilities.hpp: In member function ‘bool cugraph::test::device_nearly_equal<type_t>::operator()(type_t, type_t) const’:
cpp/tests/utilities/check_utilities.hpp:98:20: error: ‘max’ is not a member of ‘thrust’
98 | thrust::max(thrust::max(lhs, rhs) * threshold_ratio, threshold_magnitude);
| ^~~
instantiate using lambda functions. These lambda functions may have capture
lists so that there is no default constructor, and we cannot call the default
constructor of this operator.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants