Skip to content

Commit

Permalink
FIX set n_items to 1 in FIL to avoid the BATCH_TREE_REORG issue on H100
Browse files Browse the repository at this point in the history
  • Loading branch information
dantegd committed Feb 13, 2025
1 parent c2c087f commit 307811d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cpp/src/fil/fil.cu
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,9 @@ struct forest {
// if n_items was not provided, try from 1 to MAX_N_ITEMS. Otherwise, use as-is.
int min_n_items = ssp.n_items == 0 ? 1 : ssp.n_items;
int max_n_items =
ssp.n_items == 0 ? (algo_ == algo_t::BATCH_TREE_REORG ? MAX_N_ITEMS : 1) : ssp.n_items;
// we force this to 1 to avoid running into the BATCH_TREE_REORG issue
// ssp.n_items == 0 ? (algo_ == algo_t::BATCH_TREE_REORG ? MAX_N_ITEMS : 1) : ssp.n_items;
ssp.n_items == 0 ? 1 : ssp.n_items;
for (bool cols_in_shmem : {false, true}) {
ssp.cols_in_shmem = cols_in_shmem;
for (ssp.n_items = min_n_items; ssp.n_items <= max_n_items; ++ssp.n_items) {
Expand Down

0 comments on commit 307811d

Please # to comment.