Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: correctly free memory in inflation layer #107

Merged
merged 4 commits into from
Dec 24, 2024

Conversation

Nisarg236
Copy link
Member

@Nisarg236 Nisarg236 commented Dec 23, 2024

@Nisarg236
Copy link
Member Author

credit to the original pr in nav2: ros-navigation/navigation2#4424

@Nisarg236 Nisarg236 marked this pull request as ready for review December 23, 2024 17:55
@Nisarg236 Nisarg236 requested review from corot, ayushgaud, renan028, vsamy and Karol-Szymczyk and removed request for Karol-Szymczyk December 23, 2024 17:56
@renan028
Copy link
Member

nice!

Copy link

@corot corot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just one suggestion for the next PRs: please add some context to the description, like a link to the original PR, and ideally show the improvement with a video or data

@Nisarg236 Nisarg236 merged commit f31de3d into devel Dec 24, 2024
1 check passed
@Nisarg236 Nisarg236 deleted the fix/correctly_free_memory_in_inflation_layer branch December 24, 2024 01:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants