Isp driver fixes #3695
Merged
Isp driver fixes #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@6by9, can you review please? |
6by9
reviewed
Jun 29, 2020
| s->r.height = node->q_data.height; | ||
| } else { | ||
| return -EINVAL; | ||
| } |
| s->r.top = crop.rect.y; | ||
| s->r.width = crop.rect.width; | ||
| s->r.height = crop.rect.height; | ||
| } |
Add V4L2_SEL_TGT_CROP_DEFAULT and V4L2_SEL_TGT_CROP_BOUND targets. Disable the appropriate ioctls for the meta capture nodes - this now passes v4l2-compliance tests. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Register the video node at the end of the probe, swapping order with registering the controls. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Rename pad_[] to padding[]. struct bcm2835_isp_rational.den is now unsigned. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
|
LGTM |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Jul 2, 2020
kernel: drm/vc4: Allow interlaced HDMI modes from FKMS See: raspberrypi/linux#3698 kernel: Isp driver fixes See: raspberrypi/linux#3695 kernel: Add Bluetooth overlays See: raspberrypi/linux#3682 firmware: arm_loader: Allow interlaced HDMI modes from FKMS See: raspberrypi/linux#3698 firmware: arm_loader: Limit rather than reject boosts with disable_auto_turbo firmware: i2c: Clearing the TA bit may time out See: #1422 firmware: arm_loader: Add an accelerated memmove firmware: arm_loader: memmove kernel to preferred text_offset See: #1421 firmware: filesystem: Fix GPT regression on USB after SD fix See: #1420 firmware: bootloader: Some tweaks for LED, UART, USB timeouts
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Jul 2, 2020
kernel: drm/vc4: Allow interlaced HDMI modes from FKMS See: raspberrypi/linux#3698 kernel: Isp driver fixes See: raspberrypi/linux#3695 kernel: Add Bluetooth overlays See: raspberrypi/linux#3682 firmware: arm_loader: Allow interlaced HDMI modes from FKMS See: raspberrypi/linux#3698 firmware: arm_loader: Limit rather than reject boosts with disable_auto_turbo firmware: i2c: Clearing the TA bit may time out See: raspberrypi/firmware#1422 firmware: arm_loader: Add an accelerated memmove firmware: arm_loader: memmove kernel to preferred text_offset See: raspberrypi/firmware#1421 firmware: filesystem: Fix GPT regression on USB after SD fix See: raspberrypi/firmware#1420 firmware: bootloader: Some tweaks for LED, UART, USB timeouts
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed based on upstream review feedback comments.