Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for ezsound 6x8 soundcard #6564

Merged
merged 6 commits into from
Dec 24, 2024

Conversation

gordoste
Copy link
Contributor

Apologies for multiple PRs. I just realised I should be force-pushing to update the PR. Hopefully this one will pass all of the checks.

Summarising previous discussion for the record:
This is a new multichannel soundcard for the Pi5.
Some pcm3168a driver customisation is necessary to override a limitiation in ASoC. Hopefully, this limitation will be addressed in the next LTS kernel, at which point the customisations will no longer be needed.
The relevant modules need to be enabled in bcm2712_defconfig and DT overlays provided.

Technical details on ASoC limitation:
scenario
limitation

@pelwell
Copy link
Contributor

pelwell commented Dec 23, 2024

It all looks ok to me apart from the HAT map entry. It's intended to be a get-out-of-jail mechanism for old devices where the overlay was built into the EEPROM rather than the name of the overlay - if it's a new HAT+ then you should not need to trouble the HAT map.

The ezsound 6x8 soundcard requires the PCM3168A codec driver with
I2C support.

Signed-off-by: Stephen Gordon <gordoste@iinet.net.au>
ASoC cannot configure the codec correctly when the ADC and DAC share clock
lines and one of them is the clock producer. Add a DT binding that
overrides ASoC and forces the component into clock consumer mode.

Signed-off-by: Stephen Gordon <gordoste@iinet.net.au>
Document the new force-adc-cons/force-dac-cons DT bindings.

Signed-off-by: Stephen Gordon <gordoste@iinet.net.au>
Add the DT overlay for the ezsound 6x8 soundcard.

Signed-off-by: Stephen Gordon <gordoste@iinet.net.au>
Compile the new ezsound-6x8iso overlay.

Signed-off-by: Stephen Gordon <gordoste@iinet.net.au>
Document the new ezsound-6x8iso overlay.

Signed-off-by: Stephen Gordon <gordoste@iinet.net.au>
@gordoste
Copy link
Contributor Author

gordoste commented Dec 23, 2024

OK, I've removed the HAT map entry and tidied up the commit log a little bit. Incidentally, it could be worth adding a line in the overlay check Github action:
echo "To run overlaycheck yourself, build and install github.com/raspberrypi/utils and run 'make scripts' in your kernel dir. You may need to install the gcc-arm-linux-gnueabihf package."

@pelwell
Copy link
Contributor

pelwell commented Dec 23, 2024

Noted about the README, but the overlay check tool was updated last week to be more flexible about which version is cpp to use, such that there should no longer be a dependency on gcc-arm-linux-gnueabihf.

@gordoste
Copy link
Contributor Author

That would be nice, but I think you updated kdtc not overlaycheck. commit

@pelwell pelwell merged commit 7f36941 into raspberrypi:rpi-6.12.y Dec 24, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants