Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Incorrect computation in itransform #40

Closed
Kirill888 opened this issue Dec 20, 2018 · 0 comments
Closed

Incorrect computation in itransform #40

Kirill888 opened this issue Dec 20, 2018 · 0 comments
Labels
bug
Milestone
2.2.2

Comments

@Kirill888
Copy link
Contributor

I believe that itransform is incorrect for Affine matrices that have rotation/shear

I assume that A.itransform(pts) is equivalent to:

 pts = [A*pt for pt in pts]

It's not for affine transforms that have non-zero off-diagonal entries.

I think on this line sd <-> sb are swapped
https://github.com/sgillies/affine/blob/b125a6397c2a0ff4d7587a43b8678ee5f54765ed/affine/__init__.py#L519

Unit test only checks with scale only matrix.
Kirill888 added a commit to Kirill888/affine that referenced this issue Dec 20, 2018
@Kirill888
Fix computation in itransform
cfa5d11 
Fix for issue rasterio#40
@Kirill888 Kirill888 mentioned this issue Dec 20, 2018
Merged
sgillies pushed a commit that referenced this issue Dec 20, 2018
@Kirill888 @sgillies
Fix computation in itransform (#41)
3d1a493 
Fix for issue #40
@sgillies sgillies added the bug label Dec 20, 2018
@sgillies sgillies added this to the 2.2.2 milestone Dec 20, 2018
@sgillies sgillies mentioned this issue Dec 20, 2018
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.2.2
Development

No branches or pull requests
2 participants
@sgillies @Kirill888