Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: add missing tests for #182 #184

Merged
merged 1 commit into from
Mar 20, 2019
Merged

test: add missing tests for #182 #184

merged 1 commit into from
Mar 20, 2019

Conversation

silkentrance
Copy link
Collaborator

@silkentrance silkentrance commented Jan 12, 2019 •
edited by raszi
Loading

chore: update rimraf to latest version
chore: remove duplicate dependencies section from package.json

@silkentrance
Copy link
Collaborator Author

See also #182, #183

raszi
raszi requested changes Jan 29, 2019
View reviewed changes
Copy link
Owner

@raszi raszi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I believe the .endsWith express our intention better.

@raszi raszi changed the title Add missing tests for #182 test: add missing tests for #182 Jan 31, 2019
@silkentrance silkentrance force-pushed the gh-182 branch 2 times, most recently from 1f5c25f to ccc98ca Compare March 16, 2019 13:42
@silkentrance silkentrance requested a review from raszi March 16, 2019 14:15
@silkentrance
Copy link
Collaborator Author

Merging now, as all change requests have been met.

@silkentrance silkentrance merged commit 84cea56 into master Mar 20, 2019
@silkentrance silkentrance deleted the gh-182 branch March 20, 2019 19:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@raszi raszi Awaiting requested review from raszi

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silkentrance @raszi