Merge pull request #5 from ravip18596/develop

Develop

README.md

@@ -8,12 +8,20 @@ Assortment of python client for personal or business use
 
 ## Windows Installation
 
-```bash
+```commandline
 py -m venv venv
-souce venv/Scripts activate
+source venv\Scripts\activate
 py -m pip install python-prakashravip1
 ```
 
+## Linux/ Mac Installation
+
+```bash
+python -m venv venv
+source venv/bin/activate
+pip install python-prakashravip1
+```
+
 ## Example
 
 ```python

setup.py

@@ -5,7 +5,7 @@
 
 setuptools.setup(
     name="python-prakashravip1",
-    version="1.0",
+    version="1.0.1",
     author="Ravi Prakash",
     author_email="ravip18596@github.com",
     description="Common Python Utility and Client Tools",

src/utils/logger.py

@@ -37,9 +37,4 @@ def fetch_env_logger():
                     level=fetch_env_logger())
 
 logger = logging.getLogger(__name__)
-logger = CustomAdapter(logger, {'trace_id': None})
-
-
-def get_trace_logger(trace_id: str):
-    new_logger = logging.getLogger(__name__)
-    new_logger = CustomAdapter(new_logger, {'trace_id': trace_id})
+logger = CustomAdapter(logger, {'trace_id': None})

src/utils/trace_logger.py

@@ -1,12 +1,14 @@
 import logging
+
 from src.utils.logger import CustomAdapter, fetch_env_logger
 
 
-def get_trace_logger(trace_id: str):
+def get_trace_logger(trace_id: str) -> logging.LoggerAdapter:
     new_logger = logging.getLogger(__name__)
-    logging.basicConfig(format='%(asctime)s,%(msecs)d %(levelname)-8s [%(filename)s.%(funcName)s:%(lineno)d] %(message)s',
-                        datefmt='%Y-%m-%d:%H:%M:%S',
-                        level=fetch_env_logger())
-    new_logger = CustomAdapter(new_logger, {'trace_id': trace_id})
+    logging.basicConfig(
+        format='%(asctime)s,%(msecs)d %(levelname)-8s [%(filename)s.%(funcName)s:%(lineno)d] %(message)s',
+        datefmt='%Y-%m-%d:%H:%M:%S',
+        level=fetch_env_logger())
+    custom_logger = CustomAdapter(new_logger, {'trace_id': trace_id})
 
-    return new_logger
+    return custom_logger