Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove doctrine/annotation #284

Merged
merged 9 commits into from
Sep 15, 2023
Merged

Remove doctrine/annotation #284

merged 9 commits into from
Sep 15, 2023

Conversation

koriym
Copy link
Member

@koriym koriym commented Sep 11, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (751e66b) 100.00% compared to head (7d9b0d2) 100.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##                 2.x      #284   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       345       344    -1     
===========================================
  Files             47        47           
  Lines            939       933    -6     
===========================================
- Hits             939       933    -6
Files Changed Coverage Δ
src/di/Untarget.php 100.00% <ø> (ø)
src/di/AnnotatedClass.php 100.00% <100.00%> (ø)
src/di/AnnotatedClassMethods.php 100.00% <100.00%> (ø)
src/di/Arguments.php 100.00% <100.00%> (ø)
src/di/Bind.php 100.00% <100.00%> (ø)
src/di/BindValidator.php 100.00% <100.00%> (ø)
src/di/DependencyFactory.php 100.00% <100.00%> (ø)
src/di/InjectionPoint.php 100.00% <100.00%> (ø)
src/di/NameKeyVarString.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koriym koriym force-pushed the remove_doctrine_annotation branch from bc7e517 to ee97260 Compare September 11, 2023 23:24
@koriym koriym marked this pull request as ready for review September 11, 2023 23:25
@koriym koriym mentioned this pull request Sep 12, 2023
Merged
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@koriym koriym mentioned this pull request Sep 12, 2023
Merged
@koriym koriym merged commit fac2d0a into 2.x Sep 15, 2023
@koriym koriym deleted the remove_doctrine_annotation branch September 15, 2023 06:36
@NaokiTsuchiya NaokiTsuchiya mentioned this pull request Sep 19, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NaokiTsuchiya NaokiTsuchiya NaokiTsuchiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koriym @NaokiTsuchiya