Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Create Serializable Redis Adapter and ApcuAdapter disabled in CLI #17
Create Serializable Redis Adapter and ApcuAdapter disabled in CLI #17
Changes from 5 commits
9de40ee
2485374
f301725
70a268c
aca7043
7ce73db
583db6f
aef4fb3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新しく実装された RedisAdapter はシリアライズ可能にするために Providerを注入されるようになりましたが、
ここでのアンターゲット束縛は上記とは関係ないという理解であっていますかね?
Redis を束縛する場合は RedisProvider を使わないとコネクション情報などを利用できないのでこのアンターゲット束縛自体は意味がないのかなと。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確かにここ不要です。suggest してもらっていいでしょうか?