Skip to content

[Bug] API server make file uses golangci-lint version, that hangs #1334

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
1 of 2 tasks
blublinsky opened this issue Aug 16, 2023 · 1 comment · Fixed by #1342
Closed
1 of 2 tasks

[Bug] API server make file uses golangci-lint version, that hangs #1334

blublinsky opened this issue Aug 16, 2023 · 1 comment · Fixed by #1342
Labels
bug Something isn't working

Comments

@blublinsky
Copy link
Contributor

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

apiserver

What happened + What you expected to happen

Running make lint hangs. This is a known issue described here:
golangci/golangci-lint#3414

Reproduction script

run make lint to see the issue

Anything else

Every time

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@blublinsky blublinsky added the bug Something isn't working label Aug 16, 2023
@blublinsky
Copy link
Contributor Author

@z103cb, can you, please take this one?

z103cb added a commit to z103cb/kuberay that referenced this issue Aug 17, 2023
@z103cb
golangci_lint upgrade in API server makefile
bf62de0 
Fixes ray-project#1334
@z103cb z103cb mentioned this issue Aug 17, 2023
Merged
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump the golangci-lint version in the api server makefile z103cb/kuberay
1 participant
@blublinsky