Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Core] More structured logging in core worker #46906

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jul 31, 2024

Why are these changes needed?

Convert more logs to structured logging with fields

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Jul 31, 2024
@jjyao jjyao requested a review from rynewang July 31, 2024 21:08
@jjyao jjyao enabled auto-merge (squash) July 31, 2024 23:44
@jjyao jjyao disabled auto-merge August 1, 2024 04:45
@jjyao jjyao merged commit 358c72d into ray-project:master Aug 1, 2024
4 of 6 checks passed
@jjyao jjyao deleted the jjyao/slog branch August 1, 2024 04:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants