Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Core] Log why core worker is not idle during HandleExit #47300

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Aug 23, 2024

Why are these changes needed?

Useful for debugging

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Aug 23, 2024
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjyao jjyao merged commit 43250f4 into ray-project:master Aug 23, 2024
5 checks passed
@jjyao jjyao deleted the jjyao/dedddd branch August 23, 2024 18:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants