Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[RLlib] Cleanup evaluation folder. #48493

Merged
merged 4 commits into from
Nov 2, 2024
Merged

[RLlib] Cleanup evaluation folder. #48493

merged 4 commits into from
Nov 2, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 1, 2024 •
edited
Loading

Cleanup evaluation folder.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
79fe3ef 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added rllib RLlib related issues rllib-evaluation Bug affecting policy evaluation with RLlib. rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack labels Nov 1, 2024
@sven1977
LINT
2d8f6d9 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) November 1, 2024 16:02
@github-actions github-actions bot disabled auto-merge November 1, 2024 16:02
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 1, 2024
simonsays1980
simonsays1980 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. More old things gone. This is good.

@sven1977
wip
9ff9828 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into clea…
3257595 
…nup_evaluation_folder
@sven1977 sven1977 enabled auto-merge (squash) November 2, 2024 04:56
@sven1977 sven1977 merged commit e162165 into ray-project:master Nov 2, 2024
6 checks passed
@sven1977 sven1977 deleted the cleanup_evaluation_folder branch November 3, 2024 23:13
Jay-ju pushed a commit to Jay-ju/ray that referenced this pull request Nov 5, 2024
@sven1977 @Jay-ju
[RLlib] Cleanup evaluation folder. (ray-project#48493)
a25c6f1
@can-anyscale
Copy link
Collaborator

Broke broke #48558 and is blocking the release. I'm reverting to unblock.

@sven1977 sven1977 restored the cleanup_evaluation_folder branch November 5, 2024 15:22
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
@sven1977 @JP-sDEV
[RLlib] Cleanup evaluation folder. (ray-project#48493)
e0f8ece 
Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
@sven1977 @mohitjain2504
[RLlib] Cleanup evaluation folder. (ray-project#48493)
470aa52 
Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-evaluation Bug affecting policy evaluation with RLlib. rllib-oldstack-cleanup Issues related to cleaning up classes, utilities on the old API stack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sven1977 @can-anyscale @simonsays1980