-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[RLlib] Make opencv-python-headless default over opencv-python #48776
[RLlib] Make opencv-python-headless default over opencv-python #48776
Conversation
@@ -5,7 +5,7 @@ | |||
# Atari | |||
ale_py==0.10.1 | |||
imageio==2.34.2 | |||
opencv-python==4.8.1.78 | |||
opencv-python-headless==4.8.1.78 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks so much for the fix @ArturNiederfahrenhorst!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
81f6147
to
030af7e
Compare
…roject#48776) ## Why are these changes needed? Make `opencv-python-headless` defeault requirement for RLlib/ This is necessary, because `opencv-python` may not work in many headless environments. Signed-off-by: hjiang <dentinyhao@gmail.com>
Why are these changes needed?
Make
opencv-python-headless
defeault requirement for RLlib/This is necessary, because
opencv-python
may not work in many headless environments.