Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[RLlib] Make opencv-python-headless default over opencv-python #48776

Merged

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Why are these changes needed?

Make opencv-python-headless defeault requirement for RLlib/
This is necessary, because opencv-python may not work in many headless environments.

@ArturNiederfahrenhorst ArturNiederfahrenhorst changed the title initial [RLlib] Make opencv-python default Nov 17, 2024
@ArturNiederfahrenhorst ArturNiederfahrenhorst changed the title [RLlib] Make opencv-python default [RLlib] Make opencv-python-headless default over opencv-python Nov 17, 2024
@ArturNiederfahrenhorst ArturNiederfahrenhorst marked this pull request as ready for review November 17, 2024 17:04
@@ -5,7 +5,7 @@
# Atari
ale_py==0.10.1
imageio==2.34.2
opencv-python==4.8.1.78
opencv-python-headless==4.8.1.78
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks so much for the fix @ArturNiederfahrenhorst!

@sven1977 sven1977 enabled auto-merge (squash) November 18, 2024 08:54
@github-actions github-actions bot disabled auto-merge November 18, 2024 08:54
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 18, 2024
@sven1977 sven1977 enabled auto-merge (squash) November 18, 2024 08:54
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions bot disabled auto-merge November 18, 2024 17:48
@ArturNiederfahrenhorst ArturNiederfahrenhorst merged commit aaac19c into ray-project:master Nov 19, 2024
5 checks passed
dentiny pushed a commit to dentiny/ray that referenced this pull request Dec 7, 2024
…roject#48776)

## Why are these changes needed?

Make `opencv-python-headless` defeault requirement for RLlib/
This is necessary, because `opencv-python` may not work in many headless
environments.

Signed-off-by: hjiang <dentinyhao@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants