[train v2+tune] Propagate Train v2 feature flag from Tune driver to Train driver #49519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
justinvyu
requested review from
hongpeng-guo,
matthewdeng,
raulchen and
woshiyyya
as code owners
hongpeng-guo
approved these changes
Dec 31, 2024
justinvyu
changed the title
matthewdeng
approved these changes
Jan 3, 2025
…_revamp/propagate_trainv2_env_var
…_revamp/propagate_trainv2_env_var Signed-off-by: Justin Yu <justinvyu@anyscale.com>
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 7, 2025
…rain driver (ray-project#49519) To use the new revamped Ray Train proposed in ray-project/enhancements#57, users should set the `RAY_TRAIN_V2_ENABLED=1` feature flag environment variable on their job driver. However, if using Ray Tune to launch Ray Train jobs, this environment variable does not get propagated from the driver process to the Ray actor that is now acting as the Ray Train driver process. This PR propagates this environment variable automatically. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 9, 2025
…rain driver (ray-project#49519) To use the new revamped Ray Train proposed in ray-project/enhancements#57, users should set the `RAY_TRAIN_V2_ENABLED=1` feature flag environment variable on their job driver. However, if using Ray Tune to launch Ray Train jobs, this environment variable does not get propagated from the driver process to the Ray actor that is now acting as the Ray Train driver process. This PR propagates this environment variable automatically. Signed-off-by: Justin Yu <justinvyu@anyscale.com> Signed-off-by: Roshan Kathawate <roshankathawate@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To use the new revamped Ray Train proposed in ray-project/enhancements#57, users should set the
RAY_TRAIN_V2_ENABLED=1feature flag environment variable on their job driver. However, if using Ray Tune to launch Ray Train jobs, this environment variable does not get propagated from the driver process to the Ray actor that is now acting as the Ray Train driver process. This PR propagates this environment variable automatically.