Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Discord Timestamps] Displayed result time has incorrect time range (am/pm) #16592

Closed
jahirfiquitiva opened this issue Jan 24, 2025 · 6 comments
Closed

[Discord Timestamps] Displayed result time has incorrect time range (am/pm) #16592

jahirfiquitiva opened this issue Jan 24, 2025 · 6 comments
Labels
bug Something isn't working extension: discord-timestamps Issues related to the discord-timestamps extension extension Issues related to one of the extensions in the Store

Comments

@jahirfiquitiva
Copy link

jahirfiquitiva commented Jan 24, 2025 •
edited
Loading

Extension

https://www.raycast.com/theshadowdev/discord-timestamps

Raycast Version

1.89.1

macOS Version

Sequoia 15.2 (24C101)

Description

When generating a new timestamp set to 12 pm (or any time between 12:00 pm and 12:59 pm), it is shown as AM. It works fine with 12 am and 1 pm (13).

It might be because I have my system time set to 24 hours?

Input Result
Image Image
Image Image
Image Image

Steps To Reproduce

  • Try generating a new discord timestamp at some time between 12:00 pm and 12:59 pm.
  • Test with and without system time set to 24 hours.

Note: This seems to be a UI only issue, as the timestamp is correctly set to the right time (am or pm). Anyways, is misleading and makes users think that the timestamp will be incorrect

Current Behaviour

Any time between 12:00 pm and 12:59 pm is shown as AM

Expected Behaviour

Any time between 12:00 pm and 12:59 pm should be shown as PM
@jahirfiquitiva jahirfiquitiva added bug Something isn't working extension Issues related to one of the extensions in the Store labels Jan 24, 2025
@raycastbot raycastbot added the extension: discord-timestamps Issues related to the discord-timestamps extension label Jan 24, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Jan 24, 2025 •
edited
Loading

Thank you for opening this issue!

🔔 @thewilloftheshadow @feyli @hrueger you might want to have a look.

💡 Author and Contributors commands

The author and contributors of theshadowdev/discord-timestamps can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot close as not planned Closes the issue as not planned.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopens the issue.
  • @raycastbot assign me Assigns yourself to the issue.
  • @raycastbot good first issue Adds the "Good first issue" label to the issue.
  • @raycastbot keep this issue open Make sure the issue won't go stale and will be kept open by the bot.

@jahirfiquitiva jahirfiquitiva changed the title [Discord Timestamps] Time [Discord Timestamps] Displayed result time has incorrect time range (am/pm) Jan 24, 2025
@feyli
Copy link
Contributor

feyli commented Jan 24, 2025

Thanks for reporting this! I'll have a look at it ;)

@feyli
Copy link
Contributor

feyli commented Jan 24, 2025

It should only take one character in the code to fix this haha, I'll try to do it now

feyli added a commit to feyli/extensions that referenced this issue Jan 24, 2025
@feyli
fix(timestamps.ts): update amPm function to include noon in PM condit…
f47423d 
…ion (raycast#16592)

- Modify the condition in the amPm function to include 12 as PM.
- This change ensures that the function correctly identifies noon as PM.
@feyli feyli mentioned this issue Jan 24, 2025
Merged
5 tasks
@feyli
Copy link
Contributor

feyli commented Jan 24, 2025

Pull request is up and waiting for approval!

raycastbot added a commit that referenced this issue Jan 26, 2025
@feyli @raycastbot
Update discord-timestamps (#16598)
46f1c3a 
* fix(timestamps.ts): update amPm function to include noon in PM condition (#16592) 

- Modify the condition in the amPm function to include 12 as PM.
- This change ensures that the function correctly identifies noon as PM.

* Update CHANGELOG.md

* Update CHANGELOG.md and optimise images

---------

Co-authored-by: raycastbot <bot@raycast.com>
@feyli
Copy link
Contributor

feyli commented Jan 26, 2025

Merged!

@jahirfiquitiva
Copy link
Author

@feyli it seems like it's working as expected now! Thank you so much for the quick fix

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working extension: discord-timestamps Issues related to the discord-timestamps extension extension Issues related to one of the extensions in the Store
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jahirfiquitiva @feyli @raycastbot