Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PHP-SDK for PaymentLinks #248

Merged
merged 3 commits into from
Oct 7, 2021
Merged

PHP-SDK for PaymentLinks #248

merged 3 commits into from
Oct 7, 2021

Conversation

ankitdas13
Copy link
Contributor

added new methods in paymentLink class and update README.md

@ankitdas13 ankitdas13 requested a review from neera11 September 23, 2021 12:30
Copy link
Contributor

@neera11 neera11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -92,6 +92,30 @@ $link = $api->payment_link->fetch('plink_GiwM9xbIZqbkJp'); // fetch payment lin
$link = $api->payment_link->create(array('amount' => 98765,'description' => 'For XYZ purpose', 'customer' => array('email' => 'test@test.test'))); // create payment link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace payment_link with paymentlink in readme file and delete duplicate explanation for create method

README.md Outdated
@@ -92,6 +92,30 @@ $link = $api->payment_link->fetch('plink_GiwM9xbIZqbkJp'); // fetch payment lin
$link = $api->payment_link->create(array('amount' => 98765,'description' => 'For XYZ purpose', 'customer' => array('email' => 'test@test.test'))); // create payment link
$link = $api->payment_link->fetch('plink_GiwM9xbIZqbkJp')->cancel(); //cancel payment link

$data = json_encode(array('amount'=>500, 'currency'=>'INR', 'accept_partial'=>true, 'first_min_partial_amount'=>100, 'description' => 'For XYZ purpose', 'customer' => array('name'=>'Gaurav Kumar', 'email' => 'gaurav.kumar@example.com', 'contact'=>'+919999999999'), 'notify'=>array('sms'=>true, 'email'=>true) ,'reminder_enable'=>true , 'options'=>array('hosted_page'=>array('label'=>array('receipt'=>'Ref No.', 'description'=>'Course Name', 'amount_payable'=>'Course Fee Payable', 'amount_paid'=>'Course Fee Paid', 'partial_amount_due'=>'Fee Installment Due', 'partial_amount_paid'=>'Fee Installment Paid', 'expire_by'=>'Pay Before', 'expired_on'=>'1632223497','amount_due'=>'Course Fee Due'), 'show_preferences'=>array('issued_to'=>false))))); // Rename Labels in Payment Details Section
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove json_encode

@HancilSequeira HancilSequeira merged commit 742941e into master Oct 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants