create bodytype json #357
Merged
create bodytype json #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitdas13
added
Tested
ramth05
reviewed
Aug 31, 2023
| class Order extends Entity | ||
| { | ||
| /** | ||
| * @param $id Order id description | ||
| */ | ||
| public function create($attributes = array()) | ||
| { | ||
| $attributes = json_encode($attributes); |
There was a problem hiding this comment.
@ankitdas13 , Is there any tests needs to be updated for this?
There was a problem hiding this comment.
@ramth05 we dont have to update any where for this
There was a problem hiding this comment.
@ramth05 added negative test cases for create order
ramth05
reviewed
Sep 7, 2023
tests/CoverageTest.php
Outdated
| /** | ||
| * @covers \Razorpay\Api\Order::create | ||
| */ | ||
| public function testSetHeaderJson(){ |
There was a problem hiding this comment.
{ now started from new line
ramth05
reviewed
Sep 7, 2023
tests/ExceptionTest.php
Outdated
|
|
||
| $this->assertTrue(is_array($data->toArray())); | ||
|
|
||
| }catch(Error $e){ |
There was a problem hiding this comment.
catch must be start from new line
There was a problem hiding this comment.
catch now started from new line
ramth05
reviewed
Sep 7, 2023
tests/ExceptionTest.php
Outdated
| private function payload(){ | ||
| $date = new \DateTime(); | ||
| $receiptId = $date->getTimestamp(); | ||
| return array( |
There was a problem hiding this comment.
@ankitdas13 , please use [] for array and do the proper formatting.
There was a problem hiding this comment.
changed array() method to []
ramth05
reviewed
Sep 7, 2023
| { | ||
| $payload = $this->payload(); | ||
|
|
||
| $attribute = json_encode($payload); |
There was a problem hiding this comment.
Remove space between $attributes & try
ankitdas13
added
TestingNotRequired
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlencodetojsonwhile create order