Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename action modifies comment and string words equal to Symbol text #157

Closed
Myrslaver opened this issue May 20, 2024 · 2 comments
Closed

Comments

@Myrslaver
Copy link

Myrslaver commented May 20, 2024

Hello,
The commit 65cd66f changed the SymbolRenameOptions passed to the RenameSymbolAsync function from this

SymbolRenameOptions(RenameOverloads=true, RenameFile=true)

to this

SymbolRenameOptions(RenameOverloads = true, RenameInStrings = true, RenameInComments = true)

Which it means that every string and comment inside the solution/projects, that contains a word equal to the Symbol text, is renamed to the text of the action input.
The file which contains this modification is this one: Rename.fs, line 170.
I think this is a bug, and it should be reverted to the original.
This project is so cool btw, thank you for your work!

@Myrslaver Myrslaver changed the title Rename action modifies comment and scripts equal to Symbol text Rename action modifies comment and strings equal to Symbol text May 20, 2024
@Myrslaver Myrslaver changed the title Rename action modifies comment and strings equal to Symbol text Rename action modifies comment and string words equal to Symbol text May 20, 2024
@razzmatazz
Copy link
Owner

razzmatazz commented May 21, 2024

Hey @Myrslaver!
Thank you, I concur,–old behaviour has been restored in ccee0ef

@Myrslaver Myrslaver reopened this May 22, 2024
@razzmatazz
Copy link
Owner

I believe this has been fixed in 0.14.0, please reopen if not so.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants