Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Roslyn 4.7.0->4.9.2 #141

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

arussellk
Copy link
Contributor

@arussellk arussellk commented Mar 7, 2024

This PR fixes #140

Before any code changes, csharp-ls does not support C# 12:

#error version    Compiler version: '4.7.0-3.23416.9 (43b0b05c)'. Language version: default (11.0).

I updated the packages, built locally, and set my path to use the new executable:

$ dotnet build --configuration Release
$ mv csharp-language-server/src/CSharpLanguageServer/bin/Release/net8.0/CSharpLanguageServer csharp-language-server/src/CSharpLanguageServer/bin/Release/net8.0/csharp-ls
$ export PATH="/path/to/csharp-language-server/src/CSharpLanguageServer/bin/Release/net8.0:$PATH"

Now my editor reports C# 12 and the errors from preview features are gone:

#error version    Compiler version: '4.9.2-3.24129.6 (9934fb9e)'. Language version: 12.0.

@razzmatazz
Copy link
Owner

LGTM, lets get this in.

@razzmatazz razzmatazz merged commit abb3076 into razzmatazz:master Mar 13, 2024
2 checks passed
@arussellk arussellk deleted the rk-update-roslyn branch March 13, 2024 16:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# 12 support?
2 participants