Fixes for inlay hint

[tcx4c70]

No description provided.

[tcx4c70]

Because of the GFW of China, some screenshots can't be uploaded :)

I was testing with the following example code:

class Program
{
    static void Main()
    {
        var list = new [] { "a", "b" };
        var (x, y) = (0, "abc");
    }
}

[razzmatazz]

LGTM!

[razzmatazz]

@tcx4c70 I was wondering if it is possible to somehow remove typehints for assignments where right side already has type name mentioned, e.g. now we get this:

so I was thinking if we can do some heuristics that:

• (a) avoid type hints for "var v = new XXX()" assignments
• (b) avoid type hints for "var v = expression()" assignments

from looking at both cases above, maybe we can generalize and avoid type hints if expression on the right side already contains type name?

sorry -- maybe I should create a new issue here, but still

[razzmatazz]

I can take a look and change your code regarding inlay hints, if you agree that this warrants fixing

[razzmatazz]

we are also missing test infrastructure, which could help us greatly :(

[tcx4c70]

@tcx4c70 I was wondering if it is possible to somehow remove typehints for assignments where right side already has type name mentioned, e.g. now we get this:

so I was thinking if we can do some heuristics that:

• (a) avoid type hints for "var v = new XXX()" assignments
• (b) avoid type hints for "var v = expression()" assignments

from looking at both cases above, maybe we can generalize and avoid type hints if expression on the right side already contains type name?

@razzmatazz Sorry that I missed your reply. I also notice the duplicate type hints you mentioned, but i was busy on my work for last month and have no time to improve it. Maybe I'll investigate and imrove it on the next holiday on May.

[tcx4c70]

we are also missing test infrastructure, which could help us greatly :(

Yes, I struggled on testing during my development. Maybe we can add test infrastructure to roadmap or TODO list?

[razzmatazz]

we are also missing test infrastructure, which could help us greatly :(

Yes, I struggled on testing during my development. Maybe we can add test infrastructure to roadmap or TODO list?

I was pondering if we can steal that (or most of the bits) from ionide.fsautocomplete

lately i'm a little bit too busy but it should be possible to produce something working by copying the files in and doing some rough hacking

[razzmatazz]

i'm also not sure how they (fsautocomplete) do the testing, at which level, if in-proc or out of process --the later feels better for me