fix: Fix crash if there is no newline at the end of the last line #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Range` may extend the actual range of the text according to the doc of LSP: > ... the end position is exclusive. If you want to specify a range > that contains a line including the line ending character(s) then use > an end position denoting the start of the next line. If there is no newline at the end of the last line (which is common for files created by Vistual Studio) and client set the end of Range to the start of the next line of the last line, then csharp-ls will crash because argument is out of the range. On the other hand, we SHOULDN'T trust the value client sent to us. Signed-off-by: Adam Tao <tcx4c70@gmail.com>
|
this definitely makes sense.. will check and merge thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Rangemay extend the actual range of the text according to the doc of LSP:If there is no newline at the end of the last line (which is common for files created by Vistual Studio) and client set the end of Range to the start of the next line of the last line, then csharp-ls will crash because argument is out of the range. On the other hand, we SHOULDN'T trust the value client sent to us.