Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Error: Negative numbers should be created in combination with createPrefixUnaryExpression #46

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

st-Wook
Copy link
Contributor

@st-Wook st-Wook commented Apr 25, 2024

Error: Debug Failure. False expression: Negative numbers should be created in combination with createPrefixUnaryExpression
    at Object.createNumericLiteral (c:\Roblox\Project\node_modules\typescript\lib\typescript.js:21074:13)
    at Object.number (c:\Roblox\Project\node_modules\rbxts-transformer-flamework\out\util\factory.js:75:24)
    at buildUserMacro (c:\Roblox\Project\node_modules\rbxts-transformer-flamework\out\transformations\transformUserMacro.js:204:31)
    at c:\Roblox\Project\node_modules\rbxts-transformer-flamework\out\transformations\transformUserMacro.js:175:106
    at Array.map (<anonymous>)
    at buildUserMacro (c:\Roblox\Project\node_modules\rbxts-transformer-flamework\out\transformations\transformUserMacro.js:175:72)
    at c:\Roblox\Project\node_modules\rbxts-transformer-flamework\out\transformations\transformUserMacro.js:175:106
    at Array.map (<anonymous>)
    at buildUserMacro (c:\Roblox\Project\node_modules\rbxts-transformer-flamework\out\transformations\transformUserMacro.js:175:72)
    at transformUserMacro (c:\Roblox\Project\node_modules\rbxts-transformer-flamework\out\transformations\transformUserMacro.js:80:23)

It seems to occur in TypeScript 5.4 and later versions. (typescript PR)

@st-Wook st-Wook changed the title Fix Negative numbers should be created in combination with createPrefixUnaryExpression Fix Error: Negative numbers should be created in combination with createPrefixUnaryExpression Apr 25, 2024
Copy link
Member

@Fireboltofdeath Fireboltofdeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@Fireboltofdeath Fireboltofdeath merged commit 3a07f67 into rbxts-flamework:master Apr 25, 2024
@st-Wook st-Wook deleted the fix-error branch April 25, 2024 22:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants