Include order #23
Merged
Include order #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaloras
force-pushed
the
include-order
branch
5 times, most recently
from
7c64054 to
4744d7e
Compare
- Invoke our install as part of PROMPT_COMMAND. This allows bash-preexec to be included at any point in our configuration and it should be invoked last. This makes sure we always have access to the DEBUG trap and that PROMPT_COMMAND is most likely untampered with. - Should adress #21 and the occasional issue that gets created because bash-preexec is included improperly.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install bash-preexec after our session is started.
included at any point in our configuration and it should be invoked last.
This makes sure we always have access to the DEBUG trap and that
PROMPT_COMMAND is most likely untampered with.
bash-preexec is included improperly.