Skip to content

Add support for PHP 8 #17

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2020
Merged

Add support for PHP 8 #17

merged 1 commit into from
Oct 3, 2020

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Sep 18, 2020

No description provided.

@sprain sprain mentioned this pull request Sep 26, 2020
Closed
@rdohms
Copy link
Owner

rdohms commented Oct 3, 2020

@mnapoli can we either add PHP8 to the matrix in Travis, or migrate to GHA and then add that?

@rdohms rdohms added the Feature New feature or request label Oct 3, 2020
@mnapoli
Copy link
Contributor Author

mnapoli commented Oct 3, 2020

Oh that makes complete sense yes! I don't have the time unfortunately right now, but I'll try to contribute as soon as I can.

@rdohms
Copy link
Owner

rdohms commented Oct 3, 2020

Looks like It covered by the other PRs, I'll rebase and merge later.

@rdohms rdohms merged commit e3636f0 into rdohms:master Oct 3, 2020
@rdohms rdohms added this to the v0.2.1 milestone Oct 3, 2020
@mnapoli
Copy link
Contributor Author

mnapoli commented Oct 4, 2020

Thanks!

@mnapoli mnapoli deleted the patch-1 branch October 4, 2020 10:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
v0.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mnapoli @rdohms