GH Actions: minor tweaks #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Composer 2.2.0, the `--ignore-platform-reqs` setting can be made more specific. By using `--ignore-platform-req=php+` instead of `--ignore-platform-reqs`, only the upper bound for PHP platform requirements will be ignored, not _all_ platform requirements. Ref: https://blog.packagist.com/composer-2-2/#-ignore-platform-req-improvements
If there is a ruleset error, the `cs2pr` action doesn't receive an `xml` report and exits with a `0` error code, even though the PHPCS run failed (though not on CS errors, but on a ruleset error). This changes the GH Actions workflow to allow for that situation and still fail the build in that case.
rdohms
approved these changes
Mar 20, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH Actions: minor tweak
Since Composer 2.2.0, the
--ignore-platform-reqssetting can be made more specific.By using
--ignore-platform-req=php+instead of--ignore-platform-reqs, only the upper bound for PHP platform requirements will be ignored, not all platform requirements.Ref: https://blog.packagist.com/composer-2-2/#-ignore-platform-req-improvements
GH Actions: harden the workflow against PHPCS ruleset errors
If there is a ruleset error, the
cs2praction doesn't receive anxmlreport and exits with a0error code, even though the PHPCS run failed (though not on CS errors, but on a ruleset error).This changes the GH Actions workflow to allow for that situation and still fail the build in that case.