fix: Replace calling internal React Native scripts for launching Metro with CLI's script #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateWW
reviewed
Jan 31, 2023
packages/cli-platform-android/src/commands/buildAndroid/index.ts
Outdated
Show resolved
Hide resolved
packages/cli-platform-android/src/commands/buildAndroid/startServerInNewWindow.ts
Outdated
Show resolved
Hide resolved
packages/cli-platform-android/src/commands/buildAndroid/startServerInNewWindow.ts
Outdated
Show resolved
Hide resolved
szymonrybczak
force-pushed
the
fix/change-way-calling-metro
branch
from
e364ad1 to
d6d00ee
Compare
|
Can we verify if moving |
tido64
reviewed
Mar 1, 2023
packages/cli-platform-android/src/commands/buildAndroid/startServerInNewWindow.ts
Outdated
Show resolved
Hide resolved
tido64
reviewed
Mar 2, 2023
packages/cli-platform-android/src/commands/buildAndroid/startServerInNewWindow.ts
Show resolved
Hide resolved
|
Hey @tido64, I updated my code. Could you please take a look at it again? 🙏 |
tido64
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Looks good to me! Thanks for fixing this, @szymonrybczak ❤️
packages/cli-platform-android/src/commands/buildAndroid/startServerInNewWindow.ts
Outdated
Show resolved
Hide resolved
…erverInNewWindow.ts Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
szymonrybczak
force-pushed
the
fix/change-way-calling-metro
branch
from
8b93fc8 to
d35714c
Compare
tido64
reviewed
Mar 8, 2023
thymikee
reviewed
Mar 21, 2023
packages/cli-platform-android/src/commands/buildAndroid/startServerInNewWindow.ts
Outdated
Show resolved
Hide resolved
|
Looks good. This creates a discrepancy between running packager from CLI vs Xcode. Let's make sure we followup with changes to |
szymonrybczak
force-pushed
the
fix/change-way-calling-metro
branch
from
ca41ad7 to
a3f8681
Compare
thymikee
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1799
Replace calling internal React Native scripts for launching Metro with CLI's script.
Also this PR, changes the logic and right now it isn't starting packager from relative path, but it launches packager from
config.root.Test Plan:
yarn react-native run-android- should run correctly metro