-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: Use custom app name when getting build.gradle #2524
base: main
Are you sure you want to change the base?
fix: Use custom app name when getting build.gradle #2524
Conversation
Is this documented somewhere or is it a new config? |
If you mean the property |
yup that one 👍 thank you |
Let's fix CI failures and it's good to go for me! |
Ah, because of recent package refactors there are some merge conflicts 🥲 @TMisiukiewicz can you take a look? 🙏 |
@TMisiukiewicz let’s rebase this and we’re good to go :) |
const buildGradlePath = findBuildGradle( | ||
sourceDir, | ||
false, | ||
appName === '' ? 'app' : appName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be just appName
?
appName === '' ? 'app' : appName, | |
appName, |
Summary:
It cannot access package name from
build.gradle
when the module is named differently thanapp
. This PR is fixing it.Closes #2516
Test Plan:
android/app
folder name toandroid/test
react-native.config.js
file with the following content:android
command and verify the error about missing package name is not thrownChecklist