Skip to content

chore: switch to tinyglobby #2680

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benmccann
Copy link

Summary

https://npmgraph.js.org/?q=fast-glob - 17 dependencies
https://npmgraph.js.org/?q=tinyglobby - 2 dependencies

Test Plan

No new functionality was added, so this should be covered by existing tests

Checklist

  • Documentation is up to date.
  • Follows commit message convention described in CONTRIBUTING.md.
  • For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the performance difference between fast-glob and tinyglobby?

@benmccann
Copy link
Author

benmccann commented Jun 28, 2025

tinyglobby should be faster. Here's a benchmark from their repo:

Screenshot from 2025-06-26 10-28-43

Looks like the CI for this change is failing because Jest is outdated, so we'll either need to upgrade Jest or wait for a new release of fdir containing the commit thecodrr/fdir@76cb3a4 supporting older platforms

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👌

@benmccann benmccann marked this pull request as draft June 29, 2025 13:28
@thymikee
Copy link
Member

thymikee commented Jul 7, 2025

@benmccann any chance you could measure the perf difference in this project?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants