Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add tooltips, refactor other page nav, bump SDK, various tweaks #1096

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Simek
Copy link
Member

@Simek Simek commented Jan 1, 2024

📝 Why & how

Refs #1032

This PR adds a Radix Tooltip component, to be used on various UI elements to increase readability/accessibility.

It has been used to display score details, or to add caption to icon only buttons.

Additionally, I have updated Expo SDK and React Native to the latest releases. There were some small regressions, like lacking web specific fields in new RN bundled types, and for now I have decided to ignore them, and will look at proper fix for that in the future.

Also navigation of the other pages (popular, tending) has been altered a bit, and Trending page includes now collapsable filters section, Footer get a small UI refresh, and few tweaks has been made to elements appearance and/or interactivity.

✅ Checklist

  • Added library to react-native-libraries.json
  • Updated library in react-native-libraries.json
  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

Preview

Deploy: https://react-native-directory-nhtabox6p-rndir.vercel.app/

Screenshot 2024-01-01 at 16 04 57
Screenshot 2024-01-01 at 16 04 44
Screenshot 2024-01-01 at 16 03 41
Screenshot 2024-01-01 at 16 04 02

@Simek Simek added the deploy label Jan 1, 2024
@Simek Simek requested a review from brentvatne January 1, 2024 15:21
Copy link
Contributor

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks snazzy! :shipit:

@Simek Simek merged commit d35aaa2 into main Jan 10, 2024
3 checks passed
@Simek Simek deleted the tooltips-tweaks-sdk-bump branch January 10, 2024 10:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants