chore: integrate jsc into example on android #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2025
|
Let's wait for these PRs to be merged so we can use the latest nightly and test it out without patches, wdyt? |
cortinico
approved these changes
Feb 13, 2025
android/build.gradle.kts
Outdated
Comment on lines
13
to
20
| val reactNativeDir = findNodePackageDir("react-native") | ||
| val reactNativeManifest = file("${reactNativeDir}/package.json") | ||
| val reactNativeManifestAsJson = JsonSlurper().parseText(reactNativeManifest.readText()) as Map<*, *> | ||
| val reactNativeVersion = reactNativeManifestAsJson["version"] as String | ||
| val (major, minor, patch) = reactNativeVersion.split(".") | ||
| val rnMinorVersion = minor.toInt() | ||
| val rnPatchVersion = patch.toInt() | ||
| val prefabHeadersDir = file("${layout.buildDirectory.get()}/prefab-headers") |
There was a problem hiding this comment.
Q: Where is this coming from?
There was a problem hiding this comment.
you mean layout.buildDirectory.get()? having a warning from android studio.
originally the prefabHeadersDir basically referenced from your code on ReactAndroid
| jsBundleAssetPath: String = "index", | ||
| jsBundleFilePath: String? = null, | ||
| - isHermesEnabled: Boolean = true, | ||
| + jsRuntimeFactory: JSRuntimeFactory? = null, |
There was a problem hiding this comment.
See my comments on the PR upstream as we can't ship this change as it is, so we'll have to update the patch here as well.
We can merge it for the time being though
There was a problem hiding this comment.
updated patches and will merge this pr until the nightlies include the changes we need
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Feb 14, 2025
Summary: an effort of lean core for jsc: https://github.com/Kudo/discussions-and-proposals/blob/%40kudo/lean-core-jsc/proposals/0836-lean-core-jsc.md ## Changelog: [ANDROID] [CHANGED] - exclude `jsctooling` when `useThirdPartyJSC` gradle property is true Pull Request resolved: #49365 Test Plan: - ci passed - test from react-native-community/javascriptcore#4 Reviewed By: cipolleschi Differential Revision: D69654289 Pulled By: cortinico fbshipit-source-id: 148e07c7114dde05c2014522f9c56119f7f6f0ce
Kudo
force-pushed
the
@kudo/android-2a
branch
from
5b1c406 to
b470f03
Compare
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Feb 17, 2025
Summary: an effort of lean core for jsc: https://github.com/Kudo/discussions-and-proposals/blob/%40kudo/lean-core-jsc/proposals/0836-lean-core-jsc.md ## Changelog: [ANDROID] [CHANGED] - Allow passing custom JSRuntimeFactory to DefaultReactHost Pull Request resolved: #49366 Test Plan: - ci passed - test from react-native-community/javascriptcore#4 Reviewed By: cipolleschi Differential Revision: D69656837 Pulled By: cortinico fbshipit-source-id: ba8bf744c920a70c10fe5f6743f8dd182c88c4d4
Kudo
force-pushed
the
@kudo/android-2a
branch
from
b470f03 to
83f064a
Compare
Kudo
force-pushed
the
@kudo/android-2a
branch
from
83f064a to
99a90b1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the other option for #3 that will ultimately pull change in core
react-native.config.jsfor autolinkinguseThirdPartyJSC=trueMainApplication.getJavaScriptExecutorFactory()to useJSCExecutorFactoryJSCRuntimeFactoryto thegetDefaultReactHost(applicationContext, reactNativeHost, JSCRuntimeFactory())