Upgrade JSC past 260345 #159

jzxchiang1 · 2021-10-17T18:44:00Z

Issue Description

Unfortunately, many crypto apps rely on BigInt in JS. But WebKit didn't enable BigInt support until this changeset, which is almost a year after the currently released JSC version (i.e. 250230) was initially released.

The current version WebKitGTK 2.26.1 is from 2019. Is it possible to upgrade JSC to a more recent version?

I spoke with @Kudo and apparently he tried to update it to WebKitGTK 2.30.5, which was released in early 2021. That didn't work because:

"there was a breaking change that jsc removed the Intl toggle. so we probably would have to ship only the Intl variant and increase apk size."

Is there a way to get this to work, or alternatively to use an earlier version of WebKitGTK that doesn't have this breaking change, e.g. late 2020? Not sure when that change was introduced.

Thank you! This would be huge for the crypto space.

Version, config, any additional info

The text was updated successfully, but these errors were encountered:

jzxchiang1 · 2021-11-11T08:07:41Z

Bump, I'm wondering if this is possible, thanks!

jzxchiang1 · 2022-01-19T07:10:23Z

Bump

cortinico · 2022-01-19T11:44:23Z

Have you considered using Hermes instead? Would that address your specific problem?

ls-andrew-goodale · 2022-01-19T13:10:49Z

It looks like Hermes doesn't support BigInt yet either.
facebook/hermes#510

cortinico · 2022-01-19T15:21:12Z

It looks like Hermes doesn't support BigInt yet either. facebook/hermes#510

I see your point. I guess your best bet would be to reach out to someone at Expo and try to prioritize the whole BigInt support.

ls-andrew-goodale · 2022-01-19T15:40:21Z

The ICU library has a build tool to reduce the size of the ICU data file, and make smaller libraries for embedded use cases.
https://unicode-org.github.io/icu/userguide/icu_data/buildtool.html#overview-what-is-in-the-icu-data-file
Maybe this can be added to this project to make a smaller library for the "non-intl" build of JSC? @Kudo what do you think?

jzxchiang1 · 2022-01-20T01:54:31Z

https://unicode-org.github.io/icu/userguide/icu_data/buildtool.html#overview-what-is-in-the-icu-data-file

Yeah I would use Hermes if it supported:

BigInt
WebAssembly

That's my only blocker. Can you explain why Expo would need to prioritize BigInt support? I thought Facebook was maintaining the Hermes engine. Thanks.

Kudo · 2022-01-21T13:46:49Z

The ICU library has a build tool to reduce the size of the ICU data file, and make smaller libraries for embedded use cases. https://unicode-org.github.io/icu/userguide/icu_data/buildtool.html#overview-what-is-in-the-icu-data-file Maybe this can be added to this project to make a smaller library for the "non-intl" build of JSC? @Kudo what do you think?

@ls-andrew-goodale there're still some difference in the non-intl variant, e.g. typeof(Intl) === 'undefined'. i still think about to ship intl variant only. maybe we can do that after hermes be the default vm in react-native.

sunnylqm · 2022-06-05T15:29:23Z

An updated jsc runtime would be very much appreciated by current rn/expo web3 developers, given that jsc/hermes are hardcoded in some important deps, which makes it really difficult to adopt the juicy v8

oblador · 2022-06-12T15:10:29Z

What about releasing it as a pre-release or simply not bump the dependency in React Native? Hermes is missing some pretty basic JS features like block scoping and classes and Meta is consistently rejecting those as valid use cases, making it a non-viable option for us. It would be great to make use of the latest improvements to JSC on an opt-in basis.

Kudo · 2022-06-13T12:45:06Z

i can publish a new release on npm, just not to bump the version in react-native.

@sunnylqm i've seen you have a version already. do you mind to send us a pr?

sunnylqm · 2022-06-13T12:52:49Z

@Kudo I tried with webkitgtk version 2.27, 2.28 with some patches commented out, but unfortunately there are some crash seen in production app.

sunnylqm · 2022-06-13T12:55:47Z

With almost zero knowledge on c/c++, i am not capable and lucky enough to build version above 2.28.4 😂

Kudo · 2022-06-13T13:13:39Z

well, i can try to do the upgrade. no promise yet because i'm super busy these two months.

sunnylqm · 2022-06-15T15:39:42Z

#168
enable bigint support for the current jsc. it kinda works if you do not require much features.

Kudo · 2022-07-13T08:13:14Z

close via #169. jsc-android@next, please note that there're some breaking changes from this version. let me know whether it works for you. thanks!

antondalgren · 2023-04-27T09:44:23Z

Was #169 supposed to add support for bigint? @Kudo

antondalgren · 2023-04-27T10:57:04Z

I tried with a fresh install of react-native 0.69.10 and setting following resolution to my package.json.

  "resolutions": {
    "jsc-android": "294992.0.0"
  },

But the android version still doesn't work with bigint for me.

antondalgren · 2023-04-27T11:21:00Z

Stumbled upon this comment, facebook/react-native#35504 (comment) and it made it work for me.

@Cal-L

- react-native-community/jsc-android-buildscripts#159 (comment) - facebook/react-native#35504 (comment) - vanilla RN 0.71.6 tested working: 1n+2n, BigInt(1)+BigInt(2) - org.webkit:android-jsc-intl:+ required (which we're already using) - package.json>resolution not required (result: resolution field incompatible) Should prevent need for further pos BE patches till RN 0.71.6 upgrade e.g. #6305 cc @Cal-L But 294992.0.0 results in repo-specific dep build error to resolve (pos more): > Configure project :react-native-reanimated No AAR for react-native-reanimated found. Attempting to build from source. Android gradle plugin: 4.2.2 Gradle: 6.9 Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.9/userguide/command_line_interface.html#sec:command_line_warnings Error: Command failed: ./gradlew app:installProdDebug -PreactNativeDevServerPort=8081 OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0 Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01 Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/03 to old ns http://schemas.android.com/sdk/android/repo/addon2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/03 to old ns http://schemas.android.com/sdk/android/repo/repository2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/03 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01 FAILURE: Build failed with an exception. * Where: Build file '/Users/leo/Documents/GitHub/metamask-mobile/node_modules/react-native-reanimated/android/build.gradle' line: 1059 * What went wrong: A problem occurred evaluating project ':react-native-reanimated'. > Expected directory '/Users/leo/Documents/GitHub/metamask-mobile/node_modules/react-native/../jsc-android/dist/org/webkit/android-jsc' to contain exactly one file, however, it contains no files.

@Cal-L

- react-native-community/jsc-android-buildscripts#159 (comment) - facebook/react-native#35504 (comment) - vanilla RN 0.71.6 tested working: 1n+2n, BigInt(1)+BigInt(2) - package.json>resolution not required (result: resolution field incompatible) - org.webkit:android-jsc-intl:+ required (which we're already using) 294992.0.0 prevents need for e.g. `big-integer` shim, till RN 0.71.6 shipped #6221 294992.0.0 prevents need for BE patches, till RN 0.71.6 upgrade shipped e.g. #6305 cc @Cal-L But (the catch) 294992.0.0 results in repo-specific dep build error, possibly more deps to resolve, likely via patch(es): > Configure project :react-native-reanimated No AAR for react-native-reanimated found. Attempting to build from source. Android gradle plugin: 4.2.2 Gradle: 6.9 Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.9/userguide/command_line_interface.html#sec:command_line_warnings Error: Command failed: ./gradlew app:installProdDebug -PreactNativeDevServerPort=8081 OpenJDK 64-Bit Server VM warning: Ignoring option MaxPermSize; support was removed in 8.0 Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01 Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/03 to old ns http://schemas.android.com/sdk/android/repo/addon2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/03 to old ns http://schemas.android.com/sdk/android/repo/repository2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/03 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01 FAILURE: Build failed with an exception. * Where: Build file '/Users/leo/Documents/GitHub/metamask-mobile/node_modules/react-native-reanimated/android/build.gradle' line: 1059 * What went wrong: A problem occurred evaluating project ':react-native-reanimated'. > Expected directory '/Users/leo/Documents/GitHub/metamask-mobile/node_modules/react-native/../jsc-android/dist/org/webkit/android-jsc' to contain exactly one file, however, it contains no files.

leotm mentioned this issue May 2, 2023

feat: Upgrade jsc-android from 250230.2.1 to 294992.0.0 (@next) for BigInt MetaMask/metamask-mobile#6314

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade JSC past 260345 #159

Upgrade JSC past 260345 #159

jzxchiang1 commented Oct 17, 2021

jzxchiang1 commented Nov 11, 2021

jzxchiang1 commented Jan 19, 2022

cortinico commented Jan 19, 2022

ls-andrew-goodale commented Jan 19, 2022

cortinico commented Jan 19, 2022

ls-andrew-goodale commented Jan 19, 2022

jzxchiang1 commented Jan 20, 2022

Kudo commented Jan 21, 2022

sunnylqm commented Jun 5, 2022

oblador commented Jun 12, 2022

Kudo commented Jun 13, 2022

sunnylqm commented Jun 13, 2022 •

edited

Loading

sunnylqm commented Jun 13, 2022 •

edited

Loading

Kudo commented Jun 13, 2022

sunnylqm commented Jun 15, 2022

Kudo commented Jul 13, 2022

antondalgren commented Apr 27, 2023

antondalgren commented Apr 27, 2023

antondalgren commented Apr 27, 2023

Upgrade JSC past 260345 #159

Upgrade JSC past 260345 #159

Comments

jzxchiang1 commented Oct 17, 2021

Issue Description

Version, config, any additional info

jzxchiang1 commented Nov 11, 2021

jzxchiang1 commented Jan 19, 2022

cortinico commented Jan 19, 2022

ls-andrew-goodale commented Jan 19, 2022

cortinico commented Jan 19, 2022

ls-andrew-goodale commented Jan 19, 2022

jzxchiang1 commented Jan 20, 2022

Kudo commented Jan 21, 2022

sunnylqm commented Jun 5, 2022

oblador commented Jun 12, 2022

Kudo commented Jun 13, 2022

sunnylqm commented Jun 13, 2022 • edited Loading

sunnylqm commented Jun 13, 2022 • edited Loading

Kudo commented Jun 13, 2022

sunnylqm commented Jun 15, 2022

Kudo commented Jul 13, 2022

antondalgren commented Apr 27, 2023

antondalgren commented Apr 27, 2023

antondalgren commented Apr 27, 2023

sunnylqm commented Jun 13, 2022 •

edited

Loading

sunnylqm commented Jun 13, 2022 •

edited

Loading