Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use RNC prefix for android modules #785

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix: use RNC prefix for android modules #785

merged 1 commit into from
Jul 19, 2023

Conversation

itsramiel
Copy link
Contributor

@itsramiel itsramiel commented Jul 12, 2023

Summary

Fixes 767 for context. In the past, the android date module was registered under RNDatePickerAndroid. But when this package was updated to support the new arch, the module name was changed to be registered under RNDatePicker. The problem is that there is another popular package called react-native-date-picker , which was already registering its android module under RNDatePicker. Due to the change mentioned earlier, app that used to depend on both packages now are having a conflict as shown in the linked issue.

This pr basically changes the android module registration names to have an RNC prefix to align with other react native community packages and to resolve the conflict with the other package

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@itsramiel itsramiel changed the title chore: use RNC prefix for android modules fix: use RNC prefix for android modules Jul 12, 2023
@itsramiel itsramiel changed the title fix: use RNC prefix for android modules fix(android): use RNC prefix for android modules Jul 12, 2023
@itsramiel itsramiel changed the title fix(android): use RNC prefix for android modules fix: use RNC prefix for android modules Jul 12, 2023
@vonovak vonovak enabled auto-merge (squash) July 19, 2023 08:54
@vonovak vonovak disabled auto-merge July 19, 2023 08:54
@vonovak vonovak merged commit 2c49c2e into react-native-datetimepicker:master Jul 19, 2023
@vonovak
Copy link
Member

vonovak commented Jul 19, 2023

thank you! 🙂

@vonovak
Copy link
Member

vonovak commented Jul 19, 2023

🎉 This issue has been resolved in version 7.4.1 🎉

If this package helps you, consider sponsoring us! 🚀

@itsramiel itsramiel deleted the refactor/use-rnc-prefix-android branch July 19, 2023 13:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Native Android Runtime issue
2 participants