Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix android build issue on 0.78 #1048

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

fobos531
Copy link
Contributor

@fobos531 fobos531 commented Mar 7, 2025

Overview

@Naturalclar

Implements the fix from #1041 (comment)

Test Plan

Build the app

@fobos531 fobos531 requested a review from Naturalclar as a code owner March 7, 2025 16:00
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fobos531 thanks for the changes! could you pull the latest master branch so that CI check can run? sorry for the inconvenience

@fobos531
Copy link
Contributor Author

Hello @Naturalclar - done

Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! LGTM

@Naturalclar Naturalclar merged commit 5e16ef7 into react-native-menu:master Mar 12, 2025
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants