feat(#57): android missing action properties, ios image color #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- android action attributes (destructive, hidden, disabled) - android action title color - android action image and image color - ios image color - readme update with new props available
Naturalclar
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Thank you so much for this change!
I've tested on both iOS and Android and it looks awesome 😍
I love the small detail you put in to make the code clean as well.
Would you mind if I add you to the @react-native-menu github org so that we could collaborate to improve on this package?
No need to be super active, just wanted to show thanks for all the help you've made so far.
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hi, I implemented missing android menu configuration which includes attributes matching iOS behavior, android icon (can be any android drawable from app's or system resources) and *color props for action title (Android only) and action image/icon
Closes #57