feat(#90): long press support #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will take a look at this shortly! |
|
Will this be merged soon? |
Naturalclar
approved these changes
Jul 3, 2021
There was a problem hiding this comment.
@mateusz1913 awesome! verified that it works on both RN 0.63 and 0.64
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hi, regarding #90 , I added
shouldOpenOnLongPressprop which changes whether menu should be opened after normal press or long pressTest Plan
Run example app and check behavior of
shouldOpenOnLongPresspropCloses #90