Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: pull docker version from docker hub #161

Closed
wants to merge 1 commit into from

Conversation

skodamarthi
Copy link

@skodamarthi skodamarthi commented Oct 28, 2022

Signed-off-by: skodamarthi susmitha_kodamarthi@intuit.com

Pinned to the latest version which is Tag 4.2.5

Fix for #130

Signed-off-by: skodamarthi <susmitha_kodamarthi@intuit.com>
@skodamarthi
Copy link
Author

@zenweasel Can you please review?

@brent-hoover
Copy link
Collaborator

@skodamarthi No this is still incorrect. The steps to do this correctly would be to:

  1. Get current version from hub.docker.com either via the api or the website
  2. When creating an API project use that current version. aka the version that was live when the project was created. This just hardcodes the version that is current today.

@brent-hoover
Copy link
Collaborator

Closing due to inactivity

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants