Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: fix the mac directories #19

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Conversation

glennawatson
Copy link
Contributor

When compiling on OSX the directories to the reference libraries could be incorrect. Fix those to what was in the old event builder.

@glennawatson glennawatson requested a review from a team June 14, 2019 14:19
@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #19 into master will decrease coverage by 0.48%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   83.38%   82.89%   -0.49%     
==========================================
  Files          36       36              
  Lines        1029     1035       +6     
  Branches      186      189       +3     
==========================================
  Hits          858      858              
- Misses        148      151       +3     
- Partials       23       26       +3
Impacted Files Coverage Δ
...rmacist.Core/Extractors/PlatformExtractors/tvOS.cs 83.33% <0%> (ø) ⬆️
...cist.Core/Extractors/PlatformExtractors/Android.cs 80% <0%> (-20%) ⬇️
...armacist.Core/Extractors/PlatformExtractors/iOS.cs 83.33% <0%> (-16.67%) ⬇️
...rmacist.Core/ReferenceLocators/ReferenceLocator.cs 86.11% <0%> (ø) ⬆️
...armacist.Core/Extractors/PlatformExtractors/Mac.cs 83.33% <0%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f09a4...07db2a2. Read the comment docs.

@glennawatson glennawatson merged commit a9576d4 into master Jun 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-fix-mac-directory branch June 14, 2019 14:28
@lock lock bot locked and limited conversation to collaborators Sep 12, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant