Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature: Now generating base classes correctly, and passing instance members #29

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

glennawatson
Copy link
Contributor

|                Method |     Mean |    Error |   StdDev |     Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------------- |---------:|---------:|---------:|----------:|------:|------:|----------:|
| MultipleDirectoryCase | 737.3 ms | 13.78 ms | 12.22 ms | 1000.0000 |     - |     - |   4.23 MB |

So a total revamp of the nuget package input system. This is before we did the base class processing:

|                Method |     Mean |    Error |   StdDev |   Median | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---------------------- |---------:|---------:|---------:|---------:|------:|------:|------:|----------:|
| MultipleDirectoryCase | 976.6 ms | 58.94 ms | 167.2 ms | 887.9 ms |     - |     - |     - |   3.93 MB |

This was the last release after we turned on dependency inclusion

|                Method |    Mean |    Error |   StdDev |     Gen 0 |     Gen 1 |     Gen 2 | Allocated |
|---------------------- |--------:|---------:|---------:|----------:|----------:|----------:|----------:|
| MultipleDirectoryCase | 11.40 s | 0.2248 s | 0.5473 s | 8000.0000 | 4000.0000 | 2000.0000 |  39.82 MB |

Slightly more memory usage due to the fact we are using a tree based system now for getting the nodes.

@glennawatson glennawatson requested a review from a team June 21, 2019 13:46
@glennawatson
Copy link
Contributor Author

So some of the major changes,

When looking up dependent assemblies check the parent's directory first, check for windows runtime and get the appropriate folder in those cases, and only check out nuget repository store at the very end. This is more likely to get our correct match. This is much closer to what the mono loader does.

@glennawatson glennawatson merged commit ca75471 into master Jun 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the glennawatson-stop-duplicates branch June 21, 2019 14:19
@lock lock bot locked and limited conversation to collaborators Sep 19, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant