-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Extend BindCommand to allow passing EventArgs for any Event in Xamarin Forms #1228
Comments
Howdy @escamoteur; some quick thoughts. Take a quick peek into the source code behind Instead of binding, codegen your extension methods using the supplied eventbuilder console app or create them yourself; they are pretty simple and do something along the lines of:
|
Ok, that is a sort of Workaround. Still I think if we offer CommandBinding we should be able to deal with this too |
Is this also impossible in Windows Forms? I cannot seem to figure it out based on available documentation, but the workaround helped a little. |
@vector-man the remarks over at #1228 (comment) apply to windows forms as well. Compose your event stream, subscribe to it and then execute the logic as need be. |
@ghuntley so you decided that this issue is no loner worth to consider? |
Do you want to request a feature or report a bug?
Improvement
What is the current behavior?
If you use BindCommand to bind to another event than the default one your command does not receive the command arguments.
Like when I tried to bind to the Swiped Event of Mr.Gesture
A XF Command will receive SwipeEventArgs. But a ReactiveCommand doesn't
So there seems to be two shortcomings in the current implementation.
Also I question if passing the EventName of a non standard event is the best solution or if it would be better directly to pass the Control events as we have access in the View to the Control already.
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI? Please also test with the latest stable and snapshot (http://docs.reactiveui.net/en/contributing/snapshot/index.html) versions.
RxUI 7 with Xamarin Forms
The text was updated successfully, but these errors were encountered: