Skip to content

Translate faq-versioning to spanish #154

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 14 commits into from
Feb 16, 2019

Conversation

alejandrogarciasalas
Copy link
Contributor

There's a few words that I am not 100% sure about the translation, some of those are:

  • breaking changes
  • major/minor version
  • package

I tried to be consistent as much as possible. I also changed the link that pointed to the english version of the semver docs to the one in spanish.

There's a few words that I am not 100% sure about the translation, some of those are:
* breaking changes
* major/minor version
* package

I tried to be consistent as much as possible. I also changed the link that pointed to the english version of the semver docs to [the one in spanish](https://semver.org/lang/es/).
Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @alejandrogarciasalas I hope you doing well! 💪

Congratulations on your first contribution to the translation of React, we appreciate it a lot 🚀 I just finshed reading the PR, great job! I just added some word changes for your concerns about major/minor versions, for example those would end up being versión importante and versión menor respectively, breaking changes would be cambios con rupturas and finally package ends up being paquete. I left you comments for must of these, some other word changes to make the reading more understandable and easy, and a note of a little piece that wasn't translated yet, and some recommendations 👌

So please read all, fix those, check that everything was translated and update the PR 🖖 Let me know any questions or when you're done. Thanks a lot again! 🥇

Darking360 and others added 7 commits February 16, 2019 10:58
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Darking360 and others added 4 commits February 16, 2019 11:05
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
@alejandrogarciasalas
Copy link
Contributor Author

Gracias @Darking360 ! Todo listo.
Let me know if there's anything else missing.

Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one detail left 😅

Co-Authored-By: alejandrogarciasalas <garciasalasalejandro@gmail.com>
@alejandrogarciasalas
Copy link
Contributor Author

listo y gracias de nuevo!

Copy link
Collaborator

@Darking360 Darking360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @alejandrogarciasalas ! Just fix 3 more issues that I didn't see before 🚀 Great work! Welcome aboard 💪

Fixing last 3 issues.
@alejandrogarciasalas
Copy link
Contributor Author

done ✅

@Darking360 Darking360 merged commit 778f2c2 into reactjs:master Feb 16, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants