Skip to content

Accessibility translation #74

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 8 commits into from
Feb 23, 2019

Conversation

ElRodrigote
Copy link
Contributor

No description provided.

@alejandronanez
Copy link
Member

Hey @ElRodrigote, what's the state of this PR? Are you still working on it?

Thanks!

@ElRodrigote
Copy link
Contributor Author

@alejandronanez Hi!

Yes, I had a few personal issues this week but I'm working on it, I'll update now what I have so far. Sorry for the delay and not giving you guys an update status.

@alejandronanez
Copy link
Member

all good @ElRodrigote no problem! thanks for letting us know!

@ElRodrigote
Copy link
Contributor Author

Hi @alejandronanez !

Finally I've finished translating and proof reading the file, it was quite extensive haha, sorry for the delay, If you could please take a look and review it, it would be awesome.

I have a quick question, regarding titles having some kind of reference between braces. I've deleted them in the file, but would like to know if I should:
· Keep them as they are
· Translate them in situ
· Erase them

Cheers!

@alejandronanez alejandronanez self-requested a review February 21, 2019 00:45
@alejandronanez alejandronanez changed the title WIP: Accessibility translation Accessibility translation Feb 21, 2019
Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ElRodrigote, thanks for this!

Generally speaking, I see 3 things that we need to change.

  1. Bring back the # next to the titles
  2. Please, avoid the usage of usted in any form, we're writing everything with
  3. Remove the extra spaces in line # 9, all the text is bold now :D

Thank you,

@ElRodrigote
Copy link
Contributor Author

Hi @alejandronanez !

Thanks for the corrections and the review. I've noticed a few orthographic errors too so I fixed them. Please, let me know if any further changes are needed.

Cheers!
Rodrigo Ali.

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for es-reactjs ready!

Built with commit feb73b6

https://deploy-preview-74--es-reactjs.netlify.com

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @ElRodrigote, thanks for your hard work!

@ElRodrigote
Copy link
Contributor Author

Thank you guys!

@alejandronanez alejandronanez merged commit 2561d0e into reactjs:master Feb 23, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants