Skip to content

Home Page #4

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 27, 2019
Merged

Home Page #4

merged 4 commits into from
Jun 27, 2019

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented May 20, 2019 •
edited
Loading

Translating the Home Page.

#1

@balazsorban44 balazsorban44 self-assigned this May 20, 2019
@balazsorban44 balazsorban44 changed the title Home page Home Page May 20, 2019
@tesseralis tesseralis mentioned this pull request May 20, 2019
Closed
88 tasks
@balazsorban44
Copy link
Member Author

@gergely-nagy, @FeherMarcell could you review?

gergely-nagy
gergely-nagy requested changes Jun 25, 2019
View reviewed changes
Copy link
Collaborator

@gergely-nagy gergely-nagy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small change requests.

gergely-nagy
gergely-nagy requested changes Jun 26, 2019
View reviewed changes
Copy link
Collaborator

@gergely-nagy gergely-nagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React is a pure library, not a framework.

@balazsorban44
Copy link
Member Author

React is a pure library, not a framework.

@gergely-nagy
I was aware of it, don't know how I ended up writing it wrong 😶. Thanks for the catch! 😛

@balazsorban44 @gergely-nagy
🤝 apply suggestions from code review
72e89a9 
Co-Authored-By: Gergely Nagy <gergely.nagy.contact@gmail.com>
gergely-nagy
gergely-nagy approved these changes Jun 27, 2019
View reviewed changes
Copy link
Collaborator

@gergely-nagy gergely-nagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balazsorban44 balazsorban44 merged commit 257394a into master Jun 27, 2019
@balazsorban44 balazsorban44 deleted the home-page branch February 27, 2020 10:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gergely-nagy gergely-nagy gergely-nagy approved these changes

@FeherMarcell FeherMarcell Awaiting requested review from FeherMarcell

Assignees

@balazsorban44 balazsorban44

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balazsorban44 @gergely-nagy