Skip to content

Translate Virtual DOM and Internals #132

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Conversation

syug
Copy link
Contributor

@syug syug commented Feb 18, 2019

This is a part of #4, based on the Crowdin translation here.
Reviewお願いいたします 🙏

@smikitky smikitky self-requested a review February 18, 2019 17:27
@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 18, 2019
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

訳語や記号の使用法統一に関わるサジェスチョンが主になります。確認をお願いします。

@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 18, 2019
@syug
Copy link
Contributor Author

syug commented Feb 18, 2019

Reviewありがとうございます!修正しますね。

Translated the term 'reconciliation' into Japanese

Reflected reviewer's FBs
@syug
Copy link
Contributor Author

syug commented Feb 18, 2019

@smikitky Reviewありがとうございました、修正しました!ご確認よろしくお願いします。

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです!

@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for ja-reactjs ready!

Built with commit 69dcba9

https://deploy-preview-132--ja-reactjs.netlify.com

@potato4d potato4d merged commit 4c4a3a9 into reactjs:master Feb 20, 2019
@syug
Copy link
Contributor Author

syug commented Feb 20, 2019

@smikitky @potato4d Review && Mergeありがとうございました!

@tesseralis tesseralis mentioned this pull request Feb 27, 2019
90 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants