Translate Error Boundaries #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
原文での表現にかかわらず |
uenitty
force-pushed
the
feature/translate_error_boundaries
branch
from
bf70fb6 to
48729cc
Compare
|
ありがとうございます。単数表記に統一致しました 🙇 |
uenitty
force-pushed
the
feature/translate_error_boundaries
branch
from
48729cc to
53c6e4e
Compare
uenitty
force-pushed
the
feature/translate_error_boundaries
branch
from
53c6e4e to
d40581d
Compare
|
#4 (comment) に合わせてrebase & force pushしました 🙇 |
koba04
requested changes
Feb 12, 2019
content/docs/error-boundaries.md
Outdated
|
|
||
| <img src="../images/docs/error-boundaries-stack-trace-line-numbers.png" style="max-width:100%" alt="Error caught by Error Boundary component with line numbers"> | ||
|
|
||
| If you don’t use Create React App, you can add [this plugin](https://www.npmjs.com/package/babel-plugin-transform-react-jsx-source) manually to your Babel configuration. Note that it’s intended only for development and **must be disabled in production**. | ||
| Create React App を使用しない場合は、[このプラグイン](https://www.npmjs.com/package/babel-plugin-transform-react-jsx-source)を手動で Babel の設定に追加してください。 | ||
| ただし、この機能は開発専用であり、**本番では必ず無効化しなければならない**ことに注意してください。 |
koba04
approved these changes
Feb 12, 2019
smikitky
requested changes
Feb 12, 2019
Co-Authored-By: uenitty <uenitty@gmail.com>
Co-Authored-By: uenitty <uenitty@gmail.com>
uenitty
commented
Feb 12, 2019
| > * Errors thrown in the error boundary itself (rather than its children) | ||
| > * イベントハンドラ（[詳細](#how-about-event-handlers)） | ||
| > * 非同期コード（例：`setTimeout` や `requestAnimationFrame` のコールバック） | ||
| > * サーバーサイドレンダリング |
|
ありがとうございました！ |
|
こちらこそご丁寧にレビューしていただきありがとうございました！ |
|
@uenitty おめでとうございます 🎉🎉🎉 |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #4
Translation of Error Boundaries
Please review 🙏