Skip to content

Translate fragments #92

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Feb 7, 2019
Merged

Conversation

shooontan
Copy link
Contributor

This PR is part of #4

Translation of Fragments

Please review 🙏

@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 7, 2019
Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

小さな修正のみですが対応よろしくお願いします。

@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 7, 2019
smikitky and others added 4 commits February 7, 2019 15:56
Co-Authored-By: shooontan <logo.bee.doo19@gmail.com>
Co-Authored-By: shooontan <logo.bee.doo19@gmail.com>
Co-Authored-By: shooontan <logo.bee.doo19@gmail.com>
Co-Authored-By: shooontan <logo.bee.doo19@gmail.com>
@shooontan
Copy link
Contributor Author

レビューありがとうございます!

suggestion取り込みましたので再度よろしくお願いします 🙇

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

もう1件見逃していました。見出しのアンカーのURLはすべて英字のまま一切変えないでください。 reactjs/react.dev#1608 でまとめて直ります。申し訳ありませんがよろしくお願いします。

Co-Authored-By: shooontan <logo.bee.doo19@gmail.com>
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shooontan
翻訳ありがとうございます!良さそうです ✨

@potato4d potato4d merged commit aa8a90d into reactjs:master Feb 7, 2019
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
90 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants